Chore/fix rule resolve todos forms#965
Draft
bunvin wants to merge 2 commits into
Draft
Conversation
Added test to verify non-BaseModel types are rejected. Resolves TODO in forms.py line 66. Related to feldroy#645
…renamed new test_forms function to test_airform_rejects_non_basemodel_data
pydanny
requested changes
Jan 8, 2026
Member
pydanny
left a comment
pydanny
left a comment
There was a problem hiding this comment.
Looks good! Just switch back the dependency to plain fastapi and run uv lock again. 😄
| "Jinja2>=3.1.6", | ||
| "fastapi>=0.125.0", | ||
| "frozendict>=2.4.7", | ||
| "fastapi[standard]>=0.125.0", |
Member
There was a problem hiding this comment.
This change is not necessary for this PR. Can you remove it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(s)
Pull request type
Please check the type of change your PR introduces:
Pull request tasks
The following have been completed for this task:
examplesfolderChecklist
just testandjust qa, ensuring my code changes passes all existing testsDemo or screenshot
Original Issue #645
Other information
This Issue is actually 2 TODO notes in code.
this is the 1/2.
what todo: forms.py attribute data is type Any
should be changed into more specific type.
solution: based on test_forms.py type should be pydantic BaseModel
PROBLEM: after type change all example failed
also after seeing some projects using the class AirForm it seems they would fail is we change the type from Any